While playing with MySQL 5.7.5 on POWER8, I came across a rather interesting bug (74775 – and this is not the only one… I think I have a decent amount of auditing and patching to do now) which made me want to write a bit on memory barriers and the volatile keyword.
Memory barriers are hard.
Like, super hard. It’s the kind of thing that makes you curse hardware designers, probably because they’re not magically solving all your problems for you. Basically, as you get more CPU cores and each of them have caches, it gets more expensive to keep everything in sync. It’s quite obvious that with *ahem* an eventually consistent model, you could save a bunch of time and effort at the expense of shifting some complexity into software.
Those in the MySQL world should recognize this – we’ve been dealing with asynchronous replication for well over a decade as a good way to scale.
On some CPU architectures (POWER for example) not all loads are created equal. When you load a value from memory, it will be consistent with your thread of execution. That is, with any stores that you have done in this thread of execution. If another thread updates that memory location you may not see that update even if your load occurs after that thread updates that memory location. Think eventually consistent.
If you want up to date reads (and not clobber writes), then you get to do memory barriers! (a topic for elsewhere – the PowerISA document has good explanations of what we have on POWER though, and how load with reserve works).
What the volatile keyword does is generate load and store instructions. It is useful when talking to hardware, as the load and store instructions are actually doing something there that the compiler doesn’t know about and thus shouldn’t optimize away.
The volatile keyword does not add any memory barriers. This is important to realize – volatile just makes loads and stores happen for your thread, not in relation to any other threads of execution. Thus, you cannot use volatile as a thread synchronization mechanism at all. It is completely and totally wrong.
Basically, if you have a volatile variable and you do stores to it in one thread and loads in another, after the store happens, it could be quite a long time before the thread doing the loads sees it! For some applications this may be okay (although I can’t really think of any beyond very very inaccurate status variables)… but if it matters at all for application correctness, volatile is the wrong thing to use.
Further reading:
New #mysql planet post : volatile considered harmful http://t.co/K8vLM2304A
#MySQL volatile considered harmful – While playing with MySQL 5.7.5 on POWER8, I came across a rather interesting … http://t.co/tc7g7h460H
volatile considered harmful http://t.co/DbLDw1zhFI
volatile considered harmful http://t.co/P1P5HXbvNu
RT @stewartsmith: volatile considered harmful: While playing with MySQL 5.7.5 on POWER8, I came across a rather interesting bug (7… http:…
Start you audit by looking at all calls to os_thread_sleep in InnoDB. That code should be replaced and I assume the InnoDB team is interested in doing that. I filed a bug for this a few years back and there has been progress — http://bugs.mysql.com/bug.php?id=68588
volatile considered harmful – http://t.co/tSRiQX9vQL